Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement poseidon2 #413

Merged
merged 23 commits into from
May 16, 2024
Merged

feat: implement poseidon2 #413

merged 23 commits into from
May 16, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR implements Poseidon2 hash function.

These are the reference implementations.

@chokobole chokobole force-pushed the feat/implement-poseidon2 branch 3 times, most recently from c00e910 to 85184b6 Compare May 7, 2024 04:55
@chokobole chokobole force-pushed the feat/implement-poseidon2 branch from 85184b6 to 3ebe622 Compare May 8, 2024 11:07
@chokobole chokobole marked this pull request as ready for review May 8, 2024 11:09
@chokobole chokobole force-pushed the feat/implement-poseidon2 branch from 3ebe622 to 1be39e2 Compare May 8, 2024 14:56
@chokobole chokobole force-pushed the feat/implement-poseidon2 branch from 1be39e2 to 95873e1 Compare May 10, 2024 07:59
Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the feat/implement-poseidon2 branch from 95873e1 to add9078 Compare May 14, 2024 00:32
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

970bd23
Please fix "consistency" in the commit message
test(benchmark): benchmark only the permutation part for consistency w…
…ith Poseidon2

chokobole added 10 commits May 16, 2024 10:56
…with Poseidon2

update the Poseidon benchmark to measure only the permutation part,
aligning with the benchmarking approach used in Horizen and Plonky3
for consistency. This change ensures that benchmarking
across different implementations is standardized and comparable.
The results are not changed that much, so this commit doesn't update the
values.
@chokobole chokobole force-pushed the feat/implement-poseidon2 branch from add9078 to f480474 Compare May 16, 2024 02:02
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 538c2e5 into main May 16, 2024
3 checks passed
@chokobole chokobole deleted the feat/implement-poseidon2 branch May 16, 2024 04:40
chokobole added a commit that referenced this pull request Jun 11, 2024
chokobole added a commit that referenced this pull request Jun 11, 2024
chokobole added a commit that referenced this pull request Jun 13, 2024
chokobole added a commit that referenced this pull request Jun 13, 2024
chokobole added a commit that referenced this pull request Jun 13, 2024
chokobole added a commit that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants