-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement poseidon2 #413
Conversation
c00e910
to
85184b6
Compare
85184b6
to
3ebe622
Compare
3ebe622
to
1be39e2
Compare
tachyon/crypto/hashes/sponge/poseidon2/poseidon2_external_matrix.h
Outdated
Show resolved
Hide resolved
tachyon/crypto/hashes/sponge/poseidon2/poseidon2_external_matrix.h
Outdated
Show resolved
Hide resolved
1be39e2
to
95873e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tachyon/crypto/hashes/sponge/poseidon2/poseidon2_plonky3_external_matrix.h
Show resolved
Hide resolved
tachyon/crypto/hashes/sponge/poseidon2/poseidon2_horizen_external_matrix.h
Show resolved
Hide resolved
95873e1
to
add9078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
970bd23
Please fix "consistency" in the commit message
test(benchmark): benchmark only the permutation part for consistency w…
…ith Poseidon2
tachyon/crypto/hashes/sponge/poseidon2/poseidon2_internal_matrix_unittest.cc
Show resolved
Hide resolved
…with Poseidon2 update the Poseidon benchmark to measure only the permutation part, aligning with the benchmarking approach used in Horizen and Plonky3 for consistency. This change ensures that benchmarking across different implementations is standardized and comparable.
The results are not changed that much, so this commit doesn't update the values.
add9078
to
f480474
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a missing change from #413.
This is a missing change from #413.
This is a missing change from #413.
This is a missing change from #413.
This is a missing change from #413.
This is a missing change from #413.
Description
This PR implements Poseidon2 hash function.
These are the reference implementations.