Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial template two adic fri pcs #428

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR initially adds simple SP1 code to Tachyon to test SP1 Prover with Tachyon.

@chokobole chokobole requested review from ashjeong, fakedev9999, Insun35 and dongchangYoo and removed request for ashjeong and fakedev9999 June 4, 2024 12:52
@chokobole chokobole force-pushed the feat/add-initial-template-two-adic-fri-pcs branch 9 times, most recently from 51bf0b3 to 6262570 Compare June 7, 2024 05:46
@fakedev9999
Copy link
Contributor

@chokobole Could you add the reference in the commit message for the code in 912ddbd?

@chokobole chokobole force-pushed the feat/add-initial-template-two-adic-fri-pcs branch 2 times, most recently from 45d8ffb to 0421624 Compare June 7, 2024 08:19
docs/how_to_use/how_to_build.md Outdated Show resolved Hide resolved
docs/how_to_use/how_to_build.md Outdated Show resolved Hide resolved
vendors/sp1/BUILD.bazel Outdated Show resolved Hide resolved
tachyon/c/zk/plonk/halo2/BUILD.bazel Outdated Show resolved Hide resolved
vendors/sp1/BUILD.bazel Outdated Show resolved Hide resolved
@chokobole chokobole force-pushed the feat/add-initial-template-two-adic-fri-pcs branch from 0421624 to b33d82e Compare June 7, 2024 13:29
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit e182278 into main Jun 10, 2024
3 checks passed
@chokobole chokobole deleted the feat/add-initial-template-two-adic-fri-pcs branch June 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants