Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl Radix2DitParallel #441

Merged
merged 12 commits into from
Jun 27, 2024
Merged

feat: impl Radix2DitParallel #441

merged 12 commits into from
Jun 27, 2024

Conversation

ashjeong
Copy link
Contributor

@ashjeong ashjeong commented Jun 17, 2024 •
edited
Loading

In preparation for sp1, this PR implements Radix2DitParallel and its related testing.

@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch 3 times, most recently from b074fe5 to a660cf2 Compare June 18, 2024 04:09
chokobole
chokobole reviewed Jun 18, 2024
View reviewed changes
tachyon/base/bits.h Outdated Show resolved Hide resolved
tachyon/base/bits.h Outdated Show resolved Hide resolved
tachyon/base/bits.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_dit_parallel.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_dit_parallel.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_dit_parallel.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_dit_parallel.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_dit_parallel.h Outdated Show resolved Hide resolved
@chokobole
Copy link
Contributor

  • ecbb2f7 please change the type "refac(math): remove redundant qualifier"
  • d08d055 please generate two adicity generator generate_fft_prime_field().

@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch 8 times, most recently from ab44034 to 6d1d7ba Compare June 21, 2024 01:05
@ashjeong ashjeong marked this pull request as ready for review June 21, 2024 01:06
@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch from 6d1d7ba to 750e846 Compare June 21, 2024 01:24
chokobole
chokobole reviewed Jun 21, 2024
View reviewed changes
tachyon/math/matrix/matrix_utils.h Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain.h Outdated Show resolved Hide resolved
@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch from 750e846 to c330729 Compare June 21, 2024 03:12
fakedev9999
fakedev9999 reviewed Jun 21, 2024
View reviewed changes
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Show resolved Hide resolved
tachyon/math/finite_fields/baby_bear/BUILD.bazel Show resolved Hide resolved
tachyon/math/finite_fields/koala_bear/BUILD.bazel Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/naive_batch_fft.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/naive_batch_fft.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/naive_batch_fft.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/naive_batch_fft.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain_unittest.cc Outdated Show resolved Hide resolved
@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch 3 times, most recently from af9eb3e to 52a1b3b Compare June 24, 2024 02:17
@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch 2 times, most recently from 54d2afc to 5077b5f Compare June 27, 2024 07:57
dongchangYoo
dongchangYoo approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch 2 times, most recently from 0ff99dc to d5c5cdc Compare June 27, 2024 08:05
@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch from d5c5cdc to 4cc0ac3 Compare June 27, 2024 08:10
chokobole
chokobole reviewed Jun 27, 2024
View reviewed changes
tachyon/math/polynomials/univariate/mixed_radix_evaluation_domain.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/two_adic_subgroup.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/BUILD.bazel Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/two_adic_subgroup.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/two_adic_subgroup.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/two_adic_subgroup.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/two_adic_subgroup.h Outdated Show resolved Hide resolved
tachyon/math/matrix/matrix_utils.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain.h Outdated Show resolved Hide resolved
tachyon/math/polynomials/univariate/radix2_evaluation_domain.h Outdated Show resolved Hide resolved
@chokobole
Copy link
Contributor

  • dd74ef9: chore: change "panic" to "crash" in comments
  • bb5e832, a0693f1: please leave a link for the reference

ashjeong added 7 commits June 27, 2024 17:42
@ashjeong
feat(math): add matrix manipulation functions
be2eb17
@ashjeong
refac(math): change BabyBear to fft_prime_field
da095d0 
See [here](https://github.com/Plonky3/Plonky3/blob/d9ef3902abcc6a34b75f6820da168460aee26763/baby-bear/src/baby_bear.rs#L63)
@ashjeong
refac(math): change KoalaBear to fft_prime_field
7d48e57 
See [here](https://github.com/Plonky3/Plonky3/blob/d9ef3902abcc6a34b75f6820da168460aee26763/koala-bear/src/koala_bear.rs#L63)
@ashjeong
refac(math): add ability to obtain PackedPrimeField type from `Prim…
8fae137 
…eField`

For `BabyBear`, `KoalaBear`, `Mersenne31`
@ashjeong
refac(math): templatize ButterflyFnOutIn
8cc6a99
@ashjeong
feat(math): implement TwoAdicSubgroup
df90944
@ashjeong
feat(math): impl radix_2_dit_parallel functions in `radix2_evaluati…
0f02c02 
…on_domain.h`

[`Radix2DitParallel`](https://github.com/Plonky3/Plonky3/blob/main/dft/src/radix_2_dit_parallel.rs)
[`ReverseSliceIndexBits`](https://github.com/Plonky3/Plonky3/blob/33b94a8ebaf8fbaace3def6e792cba0dd97b3c42/util/src/lib.rs#L70-L83)
[Butterfly Function](https://github.com/Plonky3/Plonky3/blob/33b94a8ebaf8fbaace3def6e792cba0dd97b3c42/dft/src/butterflies.rs)
@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch 2 times, most recently from 07634b5 to 7faf0ac Compare June 27, 2024 09:05
@ashjeong ashjeong force-pushed the feat/impl-radix2ditparallel branch from 7faf0ac to fa4c33f Compare June 27, 2024 09:20
fakedev9999
fakedev9999 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chokobole
chokobole approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit bbbabd0 into main Jun 27, 2024
3 checks passed
@chokobole chokobole deleted the feat/impl-radix2ditparallel branch June 27, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fakedev9999 fakedev9999 fakedev9999 approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@chokobole chokobole chokobole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashjeong @chokobole @dongchangYoo @fakedev9999