build: remove halo2 option #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
batzor,
dongchangYoo,
fakedev9999,
GideokKim and
ashjeong
chokobole
force-pushed
the
build/remove-halo2-option
branch
from
ee25d7c to
4fcd709
Compare
ashjeong
reviewed
Jul 24, 2024
chokobole
force-pushed
the
build/remove-halo2-option
branch
from
4fcd709 to
1e35778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building a shared library for Halo2, the
--config halo2flag was necessary to set the correct subgroup generator. This PR removes that requirement by allowing the adjustment of this value at runtime.