test: optimize benchmark test #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
batzor,
dongchangYoo,
fakedev9999,
GideokKim and
ashjeong
batzor
reviewed
Jul 24, 2024
This is mostly used in benchmark, so it doesn't impact production.
This is used in MSM benchmark, so it doesn't impact production.
chokobole
force-pushed
the
test/optimize-benchmark-test
branch
from
1f9e13f to
5558b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In benchmarks, data is typically created using base::CreateVector(). However, since benchmarks generate a large amount of data, running this process in parallel is beneficial. This PR implements parallel data creation for benchmarks.