Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(benchmark): update benchmark images #494

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR updates the benchmark images based on suggestion by @ashjeong during the proof reading of medium article about Tachyon v0.3.0

  • x_label is added.
  • label of the tachyon is changed to tachyon_cpu in gpu benchmarks.

Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 3b78a64 into main Jul 29, 2024
3 checks passed
@chokobole chokobole deleted the docs/update-benchmark-images branch July 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants