Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate perfetto for profiling #507

Merged
merged 12 commits into from
Aug 9, 2024

Conversation

batzor
Copy link
Contributor

@batzor batzor commented Aug 6, 2024

Description

This PR introduces Perfetto for profiling Tachyon in various use cases.

@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch from b35b389 to 80e164e Compare August 6, 2024 04:03
@chokobole
Copy link
Contributor

Please add traces to MixedRadixEvaluationDomain as well!
Please add traces to QAP computation as well!

@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch 6 times, most recently from 97fb893 to 0458274 Compare August 6, 2024 10:05
@chokobole
Copy link
Contributor

Please add trace to ICICLE MSM/NTT, too.

tachyon/base/profiler.h Outdated Show resolved Hide resolved
tachyon/base/profiler.h Outdated Show resolved Hide resolved
tachyon/base/profiler.h Outdated Show resolved Hide resolved
tachyon/base/profiler.h Outdated Show resolved Hide resolved
tachyon/base/profiler.cc Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/circuit_test.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/halo2/prover.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/halo2/prover.h Outdated Show resolved Hide resolved
vendors/circom/prover_main.cc Outdated Show resolved Hide resolved
@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch 4 times, most recently from 7c96252 to da828a2 Compare August 7, 2024 01:08
Copy link
Contributor

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch 2 times, most recently from 75d1e22 to c65cbaf Compare August 7, 2024 08:27
@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch 2 times, most recently from b56cbb9 to a31c2aa Compare August 8, 2024 05:47
@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch 2 times, most recently from 9d9150c to a55c1bb Compare August 8, 2024 06:06
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch from 7fe5b90 to 86a11ec Compare August 8, 2024 07:31
@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch from 86a11ec to 1e7bee9 Compare August 8, 2024 07:39
@chokobole
Copy link
Contributor

@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch from 1e7bee9 to e37761f Compare August 8, 2024 07:50
docs/how_to_contribute/conventions.md Outdated Show resolved Hide resolved
docs/how_to_contribute/conventions.md Outdated Show resolved Hide resolved
docs/how_to_contribute/conventions.md Outdated Show resolved Hide resolved
docs/how_to_contribute/conventions.md Outdated Show resolved Hide resolved
@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch from e37761f to 9c76575 Compare August 8, 2024 08:55
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole requested a review from ashjeong August 8, 2024 09:23
@batzor batzor force-pushed the feat/integrate-perfetto-for-profiling branch from 75524f9 to b7caabf Compare August 9, 2024 02:05
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit a1fa13f into main Aug 9, 2024
7 checks passed
@chokobole chokobole deleted the feat/integrate-perfetto-for-profiling branch August 9, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants