perf(math): optimize radix2 domain #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
batzor,
dongchangYoo,
fakedev9999,
GideokKim and
ashjeong
chokobole
force-pushed
the
perf/optimize-radix2-domain
branch
from
7871564 to
829cb6b
Compare
chokobole
force-pushed
the
perf/optimize-radix2-domain
branch
from
829cb6b to
62c364e
Compare
GideokKim
reviewed
Aug 16, 2024
ashjeong
reviewed
Aug 16, 2024
chokobole
force-pushed
the
perf/optimize-radix2-domain
branch
2 times, most recently
from
7b8d9db to
a8d68ab
Compare
|
In ef58cee, I think you meant |
No, the methods were originally all public, and I changed |
|
LGTM |
batzor
approved these changes
Aug 19, 2024
This refactor moves the computation of the `mid` variable to where it is actually needed. This reduces the chance of mistakes when updating the `mid` value.
- parallelize swapping rows. - parallelize the multiplication between the matrix and the element.
This removes a call to `Zero()` that loops over the entire matrix.
Optimized to address several issues: 1. `conservativeResizeLike()` cannot be called with `Eigen::MatrixBase`, which is required by the next commit. 2. `conservativeResizeLike()` involves redundant large matrix creation. 3. `conservativeResizeLike()` is not parallelized.
To reduce RAM usage when calling these methods from the Rust side, inputs should not be copied. This is achieved by using `Eigen::Map<>`. The argument type is changed from `RowMajorMatrix<F>&` to `Eigen::MatrixBase<RowMajorMatrix<F>>&` to support this. See https://eigen.tuxfamily.org/dox/group__TutorialMapClass.html.
chokobole
force-pushed
the
perf/optimize-radix2-domain
branch
from
a8d68ab to
bfbecf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes
CosetLDEBatch()andIFFTBatch()in a high view.