Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable rust binding for TwoAdicFriPcs::Open() #529

Merged
merged 25 commits into from
Sep 3, 2024
Merged

feat: enable rust binding for TwoAdicFriPcs::Open() #529

merged 25 commits into from
Sep 3, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR enables rust binding for TwoAdicFriPcs::Open().

@chokobole chokobole force-pushed the feat/enable-rust-binding-for-two-adic-fri-pcs-open branch 8 times, most recently from 748be00 to 6e67fb2 Compare September 1, 2024 07:21
GideokKim
GideokKim approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would suggest unifying the case of the C API in the commit messages to make it consistent.

7eb917c
3940b3c
25e9d94

@chokobole chokobole force-pushed the feat/enable-rust-binding-for-two-adic-fri-pcs-open branch from 6e67fb2 to b355f40 Compare September 2, 2024 07:53
@chokobole
refac(c/zk): remove unused type alias
cb800b3
@chokobole
chore(c/zk): fix typo
30fdea5
@chokobole
refac!: take the field merkle tree vector as a method argument
154009c 
BREAKING CHANGE: Updates the C API and Rust binding for `TwoAdicFriPCS`
to require the Field Merkle tree vector as a method argument. This ensures
that the vector remains alive for the lifetime of `TwoAdicFriPCS`.
@chokobole
refac(sp1): remove unneeded Debug trait constraint
133bdaa
@chokobole
feat(sp1): allow DuplexChallenger to sample extension fields
04d6871 
See https://github.com/Plonky3/Plonky3/blob/eeb4e37/challenger/src/duplex_challenger.rs#L122-L142.
@chokobole
feat(sp1): add missing traits for DuplexChallenger
f34a409 
Implements necessary traits for `DuplexChallenger`, enabling a seamless
replacement of Plonky3's `DuplexChallenger` with Tachyon's version.

See below links:

- https://github.com/Plonky3/Plonky3/blob/eeb4e37/challenger/src/duplex_challenger.rs#L54-L60
- https://github.com/Plonky3/Plonky3/blob/eeb4e37/challenger/src/duplex_challenger.rs#L93-L104
- https://github.com/Plonky3/Plonky3/blob/eeb4e37/challenger/src/duplex_challenger.rs#L144-L157
- https://github.com/Plonky3/Plonky3/blob/eeb4e37/challenger/src/grinding_challenger.rs#L22-L40
@chokobole chokobole force-pushed the feat/enable-rust-binding-for-two-adic-fri-pcs-open branch from b355f40 to 75b16e7 Compare September 2, 2024 07:58
fakedev9999
fakedev9999 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongchangYoo
dongchangYoo approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the feat/enable-rust-binding-for-two-adic-fri-pcs-open branch 3 times, most recently from 9458040 to d444758 Compare September 3, 2024 06:30
batzor
batzor approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@batzor batzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashjeong
ashjeong reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5b2c5b0
Fix typo of “OpendValues” -> “OpenedValues”

9102934
Fix typo of “OpeingPoints” -> “OpeningPoints”

98fe214
Nitpicky, but can you change the commit title to “…to static”?

5d70ca1
Commit title = “…search count” -> “search counts”

tachyon/c/zk/air/sp1/baby_bear_poseidon2_opened_values.h Outdated Show resolved Hide resolved
tachyon/c/zk/air/sp1/baby_bear_poseidon2_opened_values.h Outdated Show resolved Hide resolved
tachyon/c/zk/air/sp1/baby_bear_poseidon2_opened_values.h Outdated Show resolved Hide resolved
tachyon/c/zk/air/sp1/baby_bear_poseidon2_opened_values.h Outdated Show resolved Hide resolved
@chokobole
feat(base): add Container4DTo(Hex)String()
3561304 
This utility is helpful for debugging the `OpenedValues` which is an
argument of the method `TwoAdicFriPCS::CreateOpeningProof()`
@chokobole
feat(math): remove unused feature
5498790
@chokobole
refac(crypto): add OpeningPoints and OpeningPointsForRound type
ab93fec
@chokobole
feat(c/zk): add c API for 4-dimensional vector of math::BabyBear4
aa1e2e8 
This c API addition introduces support for a 4-dimensional vector of
`math::BabyBear4`, aliased as `OpenedValues`. It is used as the return
value for `TwoAdicFriPCS::Open()`.
@chokobole chokobole force-pushed the feat/enable-rust-binding-for-two-adic-fri-pcs-open branch from d444758 to ca456b0 Compare September 3, 2024 07:59
@chokobole
feat(c/zk): add c API for 3-dimensional vector of math::BabyBear4
cc508dc 
This c API addition introduces support for a 3-dimensional vector of
`math::BabyBear4`, aliased as `OpeningPoints`. It is used as an argument
for `TwoAdicFriPCS::Open()`.
@chokobole
feat(c/zk): add c API for crypto::FRIProof
92010da
@chokobole
feat(c/crypto): add TwoAdicFriImpl::CreateOpeningProof()
bc6ecd3
@chokobole
feat(c/zk): add tachyon_sp1_baby_bear_poseidon2_two_adic_fri_open()
9194587
@chokobole
feat(rs): add Fp4
58e9aab
@chokobole
refac(math): refactor ExtensionFieldBase::GetExtendedPackedPowers()
7cff0c6
@chokobole
fix(math): fix PackRowHorizontallyPadded()
a3783e4 
Ensure `col` is incremented by `PackedField::N` in each iteration.
@chokobole
refac(math): refactor PackRowVertically()
d8a7800
@chokobole
refac(math): refactor DotExtPowers()
b44e2d1
@chokobole
refac(crypto): change ComputeInverseDenominators() to static
7d266fe
@chokobole
refac: use unpacking for decomposing return values of try_emplace()
524dc1b
@chokobole
perf(crypto): reduce the number of search counts
081d4f2
@chokobole
perf(crypto): reserve size for absl::flat_hash_map<K, V>
ef3dad4
@chokobole
perf(crypto): parallelize base::Map() in `ComputeInverseDenominator…
82a3126 
…s()`
@chokobole
feat(sp1): add rust binding for TwoAdicFriPcs::Open()
12388a0
@chokobole chokobole force-pushed the feat/enable-rust-binding-for-two-adic-fri-pcs-open branch from ca456b0 to 12388a0 Compare September 3, 2024 08:08
ashjeong
ashjeong approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit e72fd3e into main Sep 3, 2024
7 checks passed
@chokobole chokobole deleted the feat/enable-rust-binding-for-two-adic-fri-pcs-open branch September 3, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashjeong ashjeong ashjeong approved these changes

@GideokKim GideokKim GideokKim approved these changes

@fakedev9999 fakedev9999 fakedev9999 approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@batzor batzor batzor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chokobole @batzor @dongchangYoo @fakedev9999 @GideokKim @ashjeong