Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmark): fix faulty fri benchmark #540

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ashjeong
Copy link
Contributor

Fixes error made in from 76ded8d which prevented the Fri benchmark from running properly.

@ashjeong ashjeong marked this pull request as ready for review September 12, 2024 08:18
@ashjeong ashjeong changed the title fix(benchmark): fix faulty std::move fix(benchmark): fix faulty fri benchmark Sep 12, 2024
Copy link
Contributor

@batzor batzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit ddbf2db into main Sep 13, 2024
7 checks passed
@chokobole chokobole deleted the fix(benchmark)/faulty-fri-benchmark branch September 13, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants