Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: clean up fri protocol & benchmarks #551

Merged
merged 9 commits into from
Oct 18, 2024
Merged

refac: clean up fri protocol & benchmarks #551

merged 9 commits into from
Oct 18, 2024

Conversation

ashjeong
Copy link
Contributor

@ashjeong ashjeong commented Oct 16, 2024 •
edited
Loading

Fixes up minor typos and logic errors involved in FRI (+ benchmarks)

@ashjeong ashjeong changed the title chore: clean up fri protocol chore: clean up fri protocol & benchmarks Oct 17, 2024
@ashjeong ashjeong force-pushed the chore/clean-up-fri-protocol branch 3 times, most recently from 5ae9901 to d45544b Compare October 17, 2024 03:22
@ashjeong ashjeong marked this pull request as ready for review October 17, 2024 05:48
@TomTaehoonKim
Copy link
Contributor

@ashjeong Can you fix ... to _ in ee4bc3f?

@ashjeong
Copy link
Contributor Author

@ashjeong Can you fix ... to _ in ee4bc3f?

Changed from ... to (inv)!

@ashjeong ashjeong mentioned this pull request Oct 17, 2024
Merged
TomTaehoonKim
TomTaehoonKim approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GideokKim
GideokKim approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole
Copy link
Contributor

I think if you change the code for better readability, we need to type it as a refac!

@ashjeong ashjeong changed the title chore: clean up fri protocol & benchmarks refac: clean up fri protocol & benchmarks Oct 18, 2024
batzor
batzor approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@batzor batzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chokobole
chokobole approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongchangYoo
dongchangYoo approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 7bf9c56 into main Oct 18, 2024
5 checks passed
@chokobole chokobole deleted the chore/clean-up-fri-protocol branch October 18, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

@batzor batzor batzor approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@GideokKim GideokKim GideokKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashjeong @TomTaehoonKim @chokobole @batzor @dongchangYoo @GideokKim