Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(circom): delete old parts before splitting #557

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

batzor
Copy link
Contributor

@batzor batzor commented Nov 22, 2024

Description

When compiling witness generator, sometimes # of parts becomes smaller which results in trying to compile non-overwritten old circuit parts with new parts, causing conflict. This PR fixes it by removing old split parts at the start of every run.

Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 47d65cb into main Nov 25, 2024
5 checks passed
@chokobole chokobole deleted the fix/witness_generator_tool_bug branch November 25, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants