forked from kubeflow/manifests
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wait routine for m2m oidc configurator #2
Merged
kromanow94
merged 10 commits into
make-the-oidc-configurator-a-cronjob
from
make-the-oidc-configurator-a-cronjob-self-hosted
Jun 13, 2024
Merged
Improve wait routine for m2m oidc configurator #2
kromanow94
merged 10 commits into
make-the-oidc-configurator-a-cronjob
from
make-the-oidc-configurator-a-cronjob-self-hosted
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kromanow94
changed the base branch from
master
to
make-the-oidc-configurator-a-cronjob
June 12, 2024 13:08
….github/workflows/pipeline_test.yaml
…gh-actions/wait_for_pods_running_or_completed.sh
kromanow94
changed the title
Make the OIDC configurator a cronjob self hosted
Improve wait routine for m2m oidc configurator
Jun 13, 2024
kromanow94
merged commit Jun 13, 2024
2161168
into
make-the-oidc-configurator-a-cronjob
8 checks passed
kromanow94
added a commit
that referenced
this pull request
Jun 13, 2024
It was tested with self-hosted runner using custom dockerconfig credentials for debugging. Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com>
kromanow94
added a commit
that referenced
this pull request
Jun 13, 2024
It was tested with self-hosted runner using custom dockerconfig credentials for debugging. Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com>
kromanow94
added a commit
that referenced
this pull request
Jun 21, 2024
* Make the kubeflow-m2m-oidc-configurator a CronJob Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski.kr3@roche.com> Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com> * cronjob.kubeflow-m2m-oidc-configurator: concurrencyPolicy: Forbid Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski.kr3@roche.com> Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com> * add tests/gh-actions/wait_for_kubeflow_m2m_oidc_configurator.sh Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com> * Improve wait routine for m2m oidc configurator (#2) It was tested with self-hosted runner using custom dockerconfig credentials for debugging. Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com> * use docker.io/curlimages/curl for cronjob.kubeflow-m2m-oidc-configurator.yaml Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com> * make the m2m oidc configurator idempotent Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com> * verify jwks configuration in requestauthentication Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com> --------- Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski.kr3@roche.com> Signed-off-by: Krzysztof Romanowski <krzysztof.romanowski94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing... don't merge