New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unified structure for all support packages #30

Merged

Svastits merged 21 commits into master from fix/renamings

Nov 10, 2023

Member

Svastits commented Nov 10, 2023

use only lower case letters in resources

Gergely Kovacs4 and others added 12 commits

November 9, 2023 16:11


          use lower case letters

74fdd37


          start iiwa renamings (not working yet)

4fdda0f


          add prefix arg to iiwa

b9b683d


          metapackage

652a8ce


          mesh rename1

5941ca0


          mesh file rename

efba972


          iiwa urdf restruct

a53bb93


          iiwa fixes


          -sixx

dc52375


          test launch files with fake hw

73c410c


          test launc file with fake hw

d367933


          7 axis rviz config

3034c09

gavanderhoorn reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

gavanderhoorn reviewed

View reviewed changes

kuka_agilus_support/launch/test_kr6_r700-sixx.launch.py Outdated Show resolved Hide resolved

gavanderhoorn reviewed

View reviewed changes

kuka_agilus_support/urdf/kr6_r700-sixx_macro.xacro Outdated Show resolved Hide resolved


          extend moveit config joints for iiwa

c78bbc6

gavanderhoorn reviewed

View reviewed changes

kuka_lbr_iisy_support/urdf/lbr_iisy3_r760_macro.xacro Show resolved Hide resolved


          Update README.md

678e756

Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>

gavanderhoorn reviewed

View reviewed changes

kuka_lbr_iiwa_moveit_config/srdf/lbr_iiwa_arm.macro.xacro Outdated Show resolved Hide resolved

gavanderhoorn reviewed

View reviewed changes

kuka_robot_descriptions/package.xml Show resolved Hide resolved

Contributor

gavanderhoorn commented Nov 10, 2023

Apologies for the many comments. I should've submitted a review instead.


          remove dashes

577dad5

Svastits linked an issue

that may be closed by this pull request

Use only lower case letters in URDF-s #22

Closed

Aron Svastits added 4 commits

November 10, 2023 10:47


          fix auto replace

6e78728


          fix dash in readme

3285e97


          manipulator for group name in srdf

a874803


          add joint_limits for iiwa

bcd073a

Svastits mentioned this pull request

Licensing not straightforward #32

Closed

Member Author

Svastits commented Nov 10, 2023

Apologies for the many comments. I should've submitted a review instead.

Thanks for the quick review, it was perfect this way too :)
If you do not have any other comments (aside from licensing, which decision I would postpone), I will merge this PR


          maintainer email

a7a776f


          drivers rename

25ed339

Contributor

gavanderhoorn commented Nov 10, 2023

If you do not have any other comments (aside from licensing, which decision I would postpone), I will merge this PR

I've not gone over everything, but for now I believe the majority has been addressed.

I'll post issues if I believe there is something else to suggest.

Svastits merged commit a87278b into master

1 check passed

Svastits deleted the fix/renamings branch

November 10, 2023 13:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet