Remove & add some comments

krschacht · Feb 26, 2024 · 4b1f3f8 · 4b1f3f8
1 parent 6f962bd
commit 4b1f3f8
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 8 deletions.
diff --git a/src/core/drive/navigator.js b/src/core/drive/navigator.js
@@ -10,7 +10,6 @@ export class Navigator {
   }
 
   proposeVisit(location, options = {}) {
-    console.log(`proposeVisit ${location}`, options)
     if (this.delegate.allowsVisitingLocationWithAction(location, options.action)) {
       this.delegate.visitProposedToLocation(location, options)
     }
@@ -70,7 +69,6 @@ export class Navigator {
   }
 
   async formSubmissionSucceededWithResponse(formSubmission, fetchResponse) {
-    console.log(`formSubmissionSucceededWithResponse`)
     if (formSubmission == this.formSubmission) {
       const responseHTML = await fetchResponse.responseHTML
       if (responseHTML) {
@@ -82,14 +80,12 @@ export class Navigator {
         const { statusCode, redirected } = fetchResponse
         const action = this.#getActionForFormSubmission(formSubmission, fetchResponse)
         const replaceMethod = this.#getReplaceMethodForFormSubmission(formSubmission, fetchResponse)
-        console.log(`action = ${action} and replaceMethod = ${replaceMethod}`)
         const visitOptions = {
           action,
           replaceMethod,
           shouldCacheSnapshot,
           response: { statusCode, responseHTML, redirected }
         }
-        console.log(`calling proposeVisit from formSubmission`)
         this.proposeVisit(fetchResponse.location, visitOptions)
       }
     }

diff --git a/src/core/drive/page_view.js b/src/core/drive/page_view.js
@@ -17,7 +17,6 @@ export class PageView extends View {
 
   renderPage(snapshot, isPreview = false, willRender = true, visit) {
     const shouldMorphPage = this.shouldMorphPage(snapshot, visit)
-    console.log(`should morph? ${shouldMorphPage}`)
     const rendererClass = shouldMorphPage ? MorphRenderer : PageRenderer
 
     const renderer = new rendererClass(this.snapshot, snapshot, PageRenderer.renderElement, isPreview, willRender)
@@ -57,7 +56,6 @@ export class PageView extends View {
   }
 
   shouldMorphPage(snapshot, visit) {
-    console.log(`shouldMorphPage snapshot? ${snapshot.shouldMorphPage}... ${visit.action} and ${visit.replaceMethod}`)
     return snapshot.shouldMorphPage &&
             (this.isPageRefresh(visit) || this.isReplaceMethodMorph(visit))
   }

diff --git a/src/core/frames/frame_controller.js b/src/core/frames/frame_controller.js
@@ -147,6 +147,7 @@ export class FrameController {
   // Appearance observer delegate
 
   elementAppearedInViewport(element) {
+    // TODO: Determine if I need to check replaceMethod() here — I need to find the corresponding tests
     this.proposeVisitIfNavigatedWithAction(element, getVisitAction(element))
     this.#loadSourceURL()
   }

diff --git a/src/core/session.js b/src/core/session.js
@@ -228,7 +228,6 @@ export class Session {
     const replaceMethod = this.getVisitReplaceMethodForLink(link)
     const acceptsStreamResponse = link.hasAttribute("data-turbo-stream")
 
-    console.log(`followedLinkToLocation`)
     this.visit(location.href, { action, replaceMethod, acceptsStreamResponse })
   }
 

diff --git a/src/observers/form_link_click_observer.js b/src/observers/form_link_click_observer.js
@@ -53,6 +53,7 @@ export class FormLinkClickObserver {
     const turboFrame = link.getAttribute("data-turbo-frame")
     if (turboFrame) form.setAttribute("data-turbo-frame", turboFrame)
 
+    // TODO: Determine if I need to check data-turbo-replace-method here — I need to find the corresponding tests
     const turboAction = getVisitAction(link)
     if (turboAction) form.setAttribute("data-turbo-action", turboAction)
 

diff --git a/src/tests/server.mjs b/src/tests/server.mjs
@@ -171,7 +171,6 @@ router.get("/messages", (request, response) => {
 function receiveMessage(content, id, target) {
   const data = renderSSEData(renderMessage(content, id, target))
   for (const response of streamResponses) {
-    console.log("delivering message to stream", response.socket?.remotePort)
     response.write(data)
   }
 }