Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefsdata URL #18

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Fix makefsdata URL #18

merged 1 commit into from
Mar 17, 2024

Conversation

OliverKovacs
Copy link
Contributor

The current URL points to a non-existing file: https://raw.githubusercontent.com/krzmaz/lwip/e15654409d14a238aec5ed4bd5516063938c9345/src/apps/http/makefsdata/makefsdata

Thus the src/external/makefsdata file ends up being empty and no src/fsdata.c gets generated.
This results in the following error:

...
Running makefsdata script
CMake Error at src/CMakeLists.txt:18 (file):
  file RENAME failed to rename

    <path>/pico-w-webserver-example/src/fsdata.c

  to

    <path>/pico-w-webserver-example/src/my_fsdata.c

  because: No such file or directory



-- Configuring incomplete, errors occurred!
...

My change seems to result in a working build, but I basically just guessed an alternative.

@krzmaz
Copy link
Owner

krzmaz commented Mar 17, 2024

Ooops, I've deleted my fork after lwip-tcpip/lwip#15 got merged, totally forgot that it was referenced here!

Thanks for fixing this!

@krzmaz krzmaz merged commit e16b6ea into krzmaz:main Mar 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants