-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in types.based (or misconception about how it should work) #180
Comments
It should work, might be a regression. If those are known types does types.implementing.AdvancedOperation work? |
Both Advanced and Group operation are in a pod's module (whose source sourcery is indeed looking through). And the subclasses are in another pod's module. With |
Might indicate that they're not known types for some reason hmm |
Are you pointing sourcery at source code that has definition of protocols or the classes implementing them? Or both? |
Next week I'll work on #87 adding support for scanning multiple targets. This should solve an issue with 3rd party (pods) code |
I have a protocol called
Operation
. It's implemented byAdvancedOperation
, and there's another class,GroupOperation
that's itself a subclass ofAdvancedOperation
. There are then a ton ofAdvancedOperation
andGroupOperation
subclasses.With a template that starts with
{% for type in types.based.AdvancedOperation %}
, none of theGroupOperation
subclasses are targeted. If I switch it totypes.based.Operation
, nothing at all is targeted.This feels like a bug. Are recursive dependencies supported? As in, shouldn't I get all
GroupOperation
subclasses when I targetAdvancedOperation
? If not, why not, and can that feature be added? Alternatively, doing something like{% for type in types.based.AdvancedOperation|GroupOperation %}
would work for me too, but that's also not supported.The text was updated successfully, but these errors were encountered: