Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning multiple targets #193

Merged
merged 17 commits into from
Apr 4, 2017
Merged

Scanning multiple targets #193

merged 17 commits into from
Apr 4, 2017

Conversation

ilyapuchka
Copy link
Collaborator

No description provided.

@ilyapuchka ilyapuchka changed the title Targets Scanning multiple targets Mar 18, 2017
@krzysztofzablocki
Copy link
Owner

this is pretty rad, any idea why the SPM error happens ? I'm traveling but I'll try to play with this over the weekend and get you a review

@ilyapuchka
Copy link
Collaborator Author

@krzysztofzablocki looks like SPM does not work well with submodules. I think also fixed ci build issues with CommonCrypto 🎉 but looks like there is a flaky test for watcher

@krzysztofzablocki
Copy link
Owner

any chance we could get rid of submodule? it feels like we are complicating it, we already use cocoapods for dependency management

@ilyapuchka
Copy link
Collaborator Author

Sure, we can. I'd like to use it with CocoaPods too, but this framework does not support it and I don't think that publishing spec for the fork is a good idea.

@krzysztofzablocki
Copy link
Owner

are they against adding spec to their repo ?

@ilyapuchka
Copy link
Collaborator Author

I just created a PR for that tomlokhorst/XcodeEdit#19

@tomlokhorst
Copy link

Hi, I'm the developer of Xcode.swift and I noticed this issue due the PR.

Based on @ilyapuchka's work, I've added a podspec to the project (as well as Carthage and SPM support).

I intended to rename my project to XcKit, but I ran into a name conflict on CocoaPods. So as of yet I haven't released it to CocoaPods, until I can come up with a good name that isn't already taken. I'm sure Sourcery can appreciate the difficulty of naming a project. ;-)

While I haven't used Sourcery yet, I'm a big fan of code generation in general, so I appreciate this project! If you have feature requests for Xcode.swift to support Sourcery, feel free to open an issue or send a pull request. I'd be happy to help.

@ilyapuchka
Copy link
Collaborator Author

Thanks @tomlokhorst ! I actually kind of liked Xcode.swift name =)

@krzysztofzablocki
Copy link
Owner

@ilyapuchka this is ok to merge when you update changelog, might be worth adding an example how you use the new config with multiple targets / projects

@tomlokhorst
Copy link

For the dependency: I've renamed Xcode.swift to XcodeEdit, and released the CocoaPod.

You can now depend on:
pod 'XcodeEdit', '~> 1.0'
or:
.Package(url: "https://github.com/tomlokhorst/XcodeEdit.git", majorVersion: 1)

@ilyapuchka
Copy link
Collaborator Author

@tomlokhorst can you please also rename the project and the Package name to XcodeEdit? Otherwise it creates XcKit module when building with SPM and XcodeEdit for CocoaPods.

@SourceryBot
Copy link

SourceryBot commented Apr 4, 2017

1 Warning
⚠️ Big PR

Generated by 🚫 danger

@tomlokhorst
Copy link

@ilyapuchka Update the SPM dependency for XcodeEdit to version 1.0.0, instead of 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants