-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing documentation comments on declarations #1002
Conversation
I'll do a proper review on the weekend but I imagine this can have pretty significant impact on performance of tens of thousands of apps that don't really use this feature, I'm ok including this if we make it opt-in behind configuration flag but off by default would you mind adding that? If its not enabled just default to empty comment info |
I put the flag in. It touched a lot of places though; there might be a cleaner way to do it. |
@krzysztofzablocki Any update on this? |
I'll get on this soon, started new job last week so been quite busy |
Congrats! I understand that. It's not a rush, but I just wanted to make sure it was moving along :) And thank you for all you do for this project :) |
Thank you @cobbal and @krzysztofzablocki for this great feature! I'm not able to get Sourcery to parse documentation unless I pass Also, it'd be great if Sourcery docs are also updated to mention the new |
@mhdhejazi have you tried nuking old cache manually? try removing the cache and then it will re-create it on next run, let me know if you are still running into issue without Cache is under |
As mentioned in #766