chore: makes sourcery buildable starting from Xcode 13.0 / Swift 5.5 (#1045) #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't correct, you are removing dependency on libSwiftSyntax and the work that @liamnichols did to make it static instead of dynamically linked, this will break not only Mint support but all of the versions, it will fail or work depending on what Xcode people have on their machines. |
|
If we do want to go ahead with this, we'd want to keep using StaticInternalSwiftSyntaxParser, which can be done relatively simply ... I had a go in #1049 but there are a few things to think about (see the PR description) |
1 similar comment
|
If we do want to go ahead with this, we'd want to keep using StaticInternalSwiftSyntaxParser, which can be done relatively simply ... I had a go in #1049 but there are a few things to think about (see the PR description) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue of #1045. Further the size of the build artifact has been reduced dramatically. Now Sourcery is buildable starting from Xcode 13.0.