Add support for async and throwing properties to AutoMockable template #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I added support for async and throwing properties to the AutoMockable template.
I stuck to the conventions and naming format for methods that are async or throwing so hopefully will fit in nicely.
Also as part of #1100 I accidentally used newer Swift 5.7 syntax for short hand
if lethere in a Stencil macro, but nothing called that macro (it was for this PR). I've reverted to the older style anyways in this PR to not break the template for anyone using an older version of Swift.Happy for any feedback or changes that I can make to help get this merged. Thanks again :)