Separate EJSTemplate.swift for swift test and for swift build -c release #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
art-divin
changed the title
art-divin
added a commit
to art-divin/Sourcery
that referenced
this pull request
Sep 18, 2023
art-divin
added a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1202
Context
Introduced by #1188.
For
swift testto work, a different way of searching forejstemplate on macOS was implemented according to "best practices" due to issues with SPM (more info here).But the problem with this is that when running Sourcery from CLI, it is packaged differently for
releasemode, and so, it cannot find the required resources like forswift test.Workaround
swift testswift testand put it under#if DEBUGbecauseswift testruns tests in DEBUG, and Sourcery CLI is distributed with-c releasecompilation mode.Notes
There are missing integration tests because otherwise I would not merge that MR. So, I have added this use case to explore into TODO - #1198 .