Implemented Proper Protocol Composition Type Parsing #1314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #815
Context
Currently Sourcery does not properly parse types which are declared as a combination of a class and protocol.
here in this example, type
A
would not haveC
orP
in itsimplements
,inherits
,based
collections.This PR adds this possibility for accessing types if the declaration is combining them, but also, this PR removes all
Class
instances fromimplements
when such combination ofClass & Protocol
is used in the type declaration.This behaviour is different from how it was working before, where
Class
instances were put intoimplements
after parsingProtocolComposition
, which was against the documentation and common sense.