Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to fix build on Xcode 13 and support Swift 5.5 #991

Closed

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Sep 23, 2021

This tries to fix #989 and add support for Swift 5.5.

I think that I also need to update lib_InternalSwiftSyntaxParser.dylib but I don't know how.

@krzysztofzablocki
Copy link
Owner

@4brunu thanks🙇 can you copy lib_InternalSwiftSyntaxParser.dylib from Xcode 13 folder? it should be in /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx

@4brunu
Copy link
Contributor Author

4brunu commented Sep 23, 2021

Thanks for the guidance, it's done.
I'm not sure if something is still missing or if it's now complete

@4brunu
Copy link
Contributor Author

4brunu commented Sep 23, 2021

I found another issue with the XcodeProj that doesn't build with the Xcode 13, I'm also upgrading it now.

@4brunu
Copy link
Contributor Author

4brunu commented Sep 23, 2021

@krzysztofzablocki after upgrading the dependency XcodeProj it now builds in the SPM project.
But I'm not sure why the CI is failing.
Any tip on this?

@4brunu
Copy link
Contributor Author

4brunu commented Sep 23, 2021

I tried to run locally bundle exec rake validate_docs, since it's the command that is failing on CI, and it passes locally.

@krzysztofzablocki
Copy link
Owner

I'll figure it out, I want to spend some time on sunday to get pr's in and make a new release

@4brunu
Copy link
Contributor Author

4brunu commented Sep 24, 2021

Thanks 👍

@Cyberbeni
Copy link
Contributor

Since PathKit had to be updated due to a breaking change, it also breaks compatibility the other way too. You have to update the circleci config to use Xcode 13:

xcode: "12.4.0"

@4brunu
Copy link
Contributor Author

4brunu commented Sep 24, 2021

Thanks for the tip, I have updated it, let's see if CI now passes 👍

@4brunu
Copy link
Contributor Author

4brunu commented Sep 24, 2021

That did help and we have some progress, but now it shows the error:

#!/bin/bash --login -eo pipefail
bundle exec rake tests
tput: No value for $TERM and no -T specified

== Running Unit Tests ==

set -o pipefail && xcodebuild -scheme sourcery | xcpretty -c
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:x86_64, id:564DBC60-8304-2C30-DE75-FB010DB1F0F8 }
{ platform:macOS, arch:x86_64, variant:Mac Catalyst, id:564DBC60-8304-2C30-DE75-FB010DB1F0F8 }
{ platform:macOS, name:Any Mac }
{ platform:macOS, variant:Mac Catalyst, name:Any Mac }
xcodebuild: error: Building a Swift package requires that a destination is provided using the "-destination" option. The "-showdestinations" option can be used to list the available destinations.
rake aborted!
Command failed with status (70): [set -o pipefail && xcodebuild -scheme sour...]

@krzysztofzablocki
Copy link
Owner

brought in #992, thanks for this @4brunu, I'll need to figure out some swift template stuff and add 2 features I wanted but should be doing release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build on Xcode 13 RC
3 participants