Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DotNet auto-build and Release on branch updates. + Configuration updates. #4

Merged
merged 9 commits into from
Dec 30, 2023
Merged

Conversation

cvyl
Copy link
Contributor

@cvyl cvyl commented Dec 26, 2023

No description provided.

@ks233
Copy link
Owner

ks233 commented Dec 27, 2023

感谢PR!其实现在发布的两个release里的dist文件夹是我从另一个vue项目生成然后手动复制过去的,这个仓库里没有那部分代码,所以自动生成发布可能有点问题。不知道有没有方法可以同时生成这边的c#程序和那边的vue页面,然后合并到一起发布?需不需要把那个仓库的东西搬过来?

另外这个规则似乎是每次main branch更新都自动生成一个release,如果只是更新一下readme它也自动生成一个release会不会太频繁了?可以改成手动控制吗?

没怎么做过开源项目,这方面了解的不多,麻烦大佬了。

@shaka0919
Copy link
Contributor

感谢PR!其实现在发布的两个release里的dist文件夹是我从另一个vue项目生成然后手动复制过去的,这个仓库里没有那部分代码,所以自动生成发布可能有点问题。不知道有没有方法可以同时生成这边的c#程序和那边的vue页面,然后合并到一起发布?需不需要把那个仓库的东西搬过来?

另外这个规则似乎是每次main branch更新都自动生成一个release,如果只是更新一下readme它也自动生成一个release会不会太频繁了?可以改成手动控制吗?

没怎么做过开源项目,这方面了解的不多,麻烦大佬了。

你可以尝试所有PR和修改在dev或者其他什么分支,累积一部分之后merge到main触发一次release。不过我也没怎么搞过auto build,只是个建议

@yihong0618
Copy link

感谢PR!其实现在发布的两个release里的dist文件夹是我从另一个vue项目生成然后手动复制过去的,这个仓库里没有那部分代码,所以自动生成发布可能有点问题。不知道有没有方法可以同时生成这边的c#程序和那边的vue页面,然后合并到一起发布?需不需要把那个仓库的东西搬过来?

另外这个规则似乎是每次main branch更新都自动生成一个release,如果只是更新一下readme它也自动生成一个release会不会太频繁了?可以改成手动控制吗?

没怎么做过开源项目,这方面了解的不多,麻烦大佬了。

可以把 vue 那个项目做成 submoudle

I cannot get it to compile using Chinese Characters
@cvyl
Copy link
Contributor Author

cvyl commented Dec 27, 2023

afbeelding
I've tried to get it to work properly for the last few hours and this is the closest I've gotten. It automatically clones the Vue repository builds it and puts it in the same place as the final ZIP. Sadly, I cannot figure out how to make it compile the DLL to Chinese Encoding.

If anyone knows how to fix that, the auto-build is complete. Currently this is how the workflow runs: https://github.com/ly-nld/ja-learner/actions/runs/7339530694/job/19983924813
https://github.com/ly-nld/ja-learner/releases/tag/release-2023%E5%B9%B412%E6%9C%8827%E6%97%A5151145

Also, assuming these were static files. They get automatically downloaded from https://github.com/ly-nld/ja-learner-static-files

@yihong0618
Copy link

I have no win env for now, maybe help you do something later

@shaka0919
Copy link
Contributor

is that possible to test the github action in a local environment?

@cvyl
Copy link
Contributor Author

cvyl commented Dec 28, 2023

is that possible to test the github action in a local environment?

Unfortunately there aren’t many solutions on running GitHub Actions locally. I personally had a lot of trail and error on a seperate forked repository. Closest thing I can find is https://github.com/nektos/act

@ks233
Copy link
Owner

ks233 commented Dec 29, 2023

I found that only the MainForm.cs is somehow encoded in gb2312. The strings displayed weirdly are all in that file. I’ve converted it to utf8bom, and I think it will now be built correctly.

@cvyl
Copy link
Contributor Author

cvyl commented Dec 29, 2023

I found that only the MainForm.cs is somehow encoded in gb2312. The strings displayed weirdly are all in that file. I’ve converted it to utf8bom, and I think it will now be built correctly.

I'll give it a try, I'll send an update soon

@cvyl
Copy link
Contributor Author

cvyl commented Dec 29, 2023

@cvyl
Copy link
Contributor Author

cvyl commented Dec 29, 2023

@ks233 ks233 merged commit d587489 into ks233:main Dec 30, 2023
@cvyl cvyl deleted the patch-1 branch December 30, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants