Skip to content
This repository has been archived by the owner on Mar 25, 2020. It is now read-only.

Add AdminPageCloudFrontDomainName and StatusPageCloudFrontDomainName outputs #131

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

salekseev
Copy link
Contributor

@salekseev salekseev commented Aug 29, 2018

This is to be able to use with external DNS provider (e.g. Cloudflare) if using custom URLs.

This is also to address some internal work on a terraform module that I may contribute back eventually to address #100.

…outputs to be able to use with external DNS provider if using custom URLs
@ks888
Copy link
Owner

ks888 commented Aug 31, 2018

Thank you for the PR! It seems new outputs are similar to existing AdminPageCloudFrontURL and StatusPageCloudFrontURL outputs. Can you tell me the difference?

@salekseev
Copy link
Contributor Author

The difference is that if you set cutom URLs those outputs contain those URLs instead of CloudFront domain name so they cannot be used to create those needed DNS CNAMEs. Introduced outputs always output CloudFront domain names so can be used to create DNS records.

@ks888
Copy link
Owner

ks888 commented Sep 4, 2018

Sorry for my late reply. I see, you want to automatically set up the DNS setting. Thank you for the clarification.

@ks888 ks888 merged commit 62b24a9 into ks888:master Sep 4, 2018
@salekseev salekseev deleted the feature_cloudfront_output branch September 11, 2018 20:05
@ks888 ks888 added this to the v0.6.5 milestone Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants