Some code cleanups to better integrate this into other packages #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRega
commented
Oct 4, 2023
ChrisRega
commented
- Segregated errors / messages
- Added convenience API for library clients
- Used clap for CLI from struct with help
- Some smaller code improvements
- Remove colored output for now - should be added again on main.rs to not taint library callers with ansi codes
Fix compilation
…nal vector initialization
0.3.1 dev
Remove extra white-space.
Add deep-sorting as an option to the API.
sort nested arrays
No sorting yet.
Feature/add ignore list
- Write better return type - Improve array return type support - Improve visual representation of diffs (more jq-like)
Improve API for library usage
… into more readable functions.
Add error message to structural problems, Refactoring comparison code…
- Add serde_json::Value parsing for PathElement - Refactor variable names
- Change the API to hand throught serde_jsons Values - Add better README.md - Bump version - Add better docs
- Rename files to be more consistent
- Add more doctests - Fix existing tests
- Add coverage to README.md
Feature/0.6.0 better error handling
- Make it a default feature - Add regex option to CLI
- Add feature for CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.