remove dependency on controller-runtime fork

[ryandawsonuk]

depending on controller-runtime fork is awkward, as discussed at #1144 (comment)

this is an attempt to remove that dependency - let's see what e2e tests say

[kubeflow-bot]

This change is 

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ryandawsonuk
To complete the pull request process, please assign deadeyegoodwin after the PR has been reviewed.
You can assign the PR to them by writing /assign @deadeyegoodwin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yuzisun]

@ryandawsonuk Did you try 0.18.6 according to last comment kubernetes-sigs/controller-runtime#1033 conroller-runtime v0.6.x should work with that?

[ryandawsonuk]

Weirdly trying that leads me to kubernetes/client-go#808. I tried to work around it with replace to bring down the gnostic version but then I get the lowercase version of the error - kubernetes/client-go#741. It seems that 1.19 does indeed fix that as this compiles with 1.19. Not looked into e2e test failures though.

[pugangxa]

/retest

[k8s-ci-robot]

@ryandawsonuk: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
kubeflow-kfserving-presubmit	f4e21bf	link	/test kubeflow-kfserving-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pugangxa]

I encountered the same error with this change as the e2e test during make deploy-dev:

The CustomResourceDefinition "inferenceservices.serving.kubeflow.org" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

[ryandawsonuk]

I encountered the same error with this change as the e2e test during make deploy-dev:

The CustomResourceDefinition "inferenceservices.serving.kubeflow.org" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

Interesting. There seem to be some threads out there online about that error.

[pugangxa]

Interesting. There seem to be some threads out there online about that error.

Yes, but maxDescLen is already set to 0 this time and it's still too long.

[pugangxa]

/lgtm

[aws-kf-ci-bot]

@ryandawsonuk: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
kubeflow-kfserving-presubmit	f4e21bf	link	/test kubeflow-kfserving-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pugangxa]

Think we can close this since PR #1341 fixed this issue.

[yuzisun]

thanks @pugangxa ! closing this.