-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exception handler for model server and Add ability to specify custom handler #3405
Add exception handler for model server and Add ability to specify custom handler #3405
Conversation
b30f693
to
4313416
Compare
@sivanantha321 : Possible to get a unit test case around this feature to test that custom exception handler is indeed getting added ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment regarding unit test , rest LGTM
4313416
to
01c618b
Compare
I tried. But I am not able to get it to work. |
…tom exception handler Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
01c618b
to
9955d28
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rachitchauhan43, sivanantha321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…tom handler (kserve#3405) Add exception handler for model server and Add ability to specify custom exception handler Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3404
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Before:
After:
Special notes for your reviewer:
Checklist:
Release note: