Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prerequisite when installing via helm #379

Closed
wants to merge 1 commit into from
Closed

Add prerequisite when installing via helm #379

wants to merge 1 commit into from

Conversation

ArangoGutierrez
Copy link

@ArangoGutierrez ArangoGutierrez commented Jul 2, 2024 •
edited
Loading

Currently by "simply" following the instructions users face with:

❯    helm install kserve oci://ghcr.io/kserve/charts/kserve --version v0.13.0

Pulled: ghcr.io/kserve/charts/kserve:v0.13.0
Digest: sha256:84ec987a507fd494e9e1e4fb8110c56594fa37609cff6bd1d6eb4b5b84386aee
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [resource mapping not found for name: "serving-cert" namespace: "default" from "": no matches for kind "Certificate" in version "cert-manager.io/v1"
ensure CRDs are installed first, resource mapping not found for name: "modelmesh-webhook-server-cert" namespace: "default" from "": no matches for kind "Certificate" in version "cert-manager.io/v1"
ensure CRDs are installed first, resource mapping not found for name: "selfsigned-issuer" namespace: "default" from "": no matches for kind "Issuer" in version "cert-manager.io/v1"

@ArangoGutierrez
Add prerequisite when installing via helm
36fea73 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for elastic-nobel-0aef7a ready!

Name Link
🔨 Latest commit 36fea73
🔍 Latest deploy log https://app.netlify.com/sites/elastic-nobel-0aef7a/deploys/66841ddf2359ff000800547d
😎 Deploy Preview https://deploy-preview-379--elastic-nobel-0aef7a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArangoGutierrez
Copy link
Author

PING @alexagriffith @theofpa

@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArangoGutierrez, terrytangyuan
Once this PR has been reviewed and has the lgtm label, please assign yuzisun for approval by writing /assign @yuzisun in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member

/lgtm
/assign @yuzisun

@oss-prow-bot oss-prow-bot bot added the lgtm label Jul 16, 2024
yuzisun
yuzisun reviewed Jul 18, 2024
View reviewed changes
docs/get_started/README.md
@@ -45,3 +45,11 @@ The [Kubernetes CLI (`kubectl`)](https://kubernetes.io/docs/tasks/tools/install-
helm install kserve-crd oci://ghcr.io/kserve/charts/kserve-crd --version v0.13.0
helm install kserve oci://ghcr.io/kserve/charts/kserve --version v0.13.0
```

This second method requires cert-manager to be installed in the cluster. If you don't have cert-manager installed, you can install it with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first method also requires cert manager but it was installed as part of the script, we can probably change quick install to support the raw deployment mode and change to use helm for installing kserve.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sivanantha321 @andyi2it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! I will raise a PR for that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean this PR is not needed any more?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PING

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised a PR here. kserve/kserve#3813

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, We can remove the helm installation here (as this docs is only for getting started and try out KServe ) and add it in the administrator guide which has step by step process for installing kserve with its prerequisites. There you can add the helm installation option. https://kserve.github.io/website/latest/admin/serverless/serverless/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will close this PR, and do another one for that

@sivanantha321 sivanantha321 mentioned this pull request Jul 23, 2024
Merged
9 tasks
@ArangoGutierrez
Copy link
Author

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexagriffith alexagriffith Awaiting requested review from alexagriffith

@theofpa theofpa Awaiting requested review from theofpa

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

@yuzisun yuzisun Awaiting requested review from yuzisun

@sivanantha321 sivanantha321 Awaiting requested review from sivanantha321

Assignees

@terrytangyuan terrytangyuan

@yuzisun yuzisun

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArangoGutierrez @terrytangyuan @yuzisun @sivanantha321