Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add mode selection filter to TimeTableScreen #608

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Feb 12, 2025

TL;DR

Added mode selection functionality to the trip planner timetable screen with a new confirmation button.

What changed?

  • Added a new ModeSelectionChanged event to handle transport mode filtering
  • Created a new check icon resource for the confirmation button
  • Implemented a "Done" button in the mode selection row that appears when filtering transport modes
  • Added handling for mode selection changes in the ViewModel
  • Extended the TimeTableScreen to support mode selection callbacks

How to test?

  1. Navigate to the timetable screen
  2. Click the filter button to show transport mode options
  3. Select/deselect different transport modes
  4. Click the "Done" button to confirm your selection
  5. Verify that the mode selection is reflected in the UI and the selection row closes

Why make this change?

To provide users with the ability to filter their journey results by transport modes, making it easier to find preferred travel options. The confirmation button ensures users can review their selections before applying the filter.

@ksharma-xyz ksharma-xyz changed the title Add ModeSelectionChanged event UI: Add mode selection filter to TimeTableScreen Feb 12, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review February 12, 2025 11:57
@ksharma-xyz ksharma-xyz changed the base branch from 02-12-works to main February 12, 2025 13:30
@ksharma-xyz ksharma-xyz force-pushed the 02-12-add_modeselectionchanged_event branch from 31d3561 to d812367 Compare February 12, 2025 13:31
Copy link
Owner Author

Merge activity

  • Feb 12, 8:31 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@ksharma-xyz ksharma-xyz force-pushed the 02-12-add_modeselectionchanged_event branch from d812367 to ea7c5c7 Compare February 12, 2025 13:52
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) February 12, 2025 13:53
@ksharma-xyz ksharma-xyz merged commit c34d0d3 into main Feb 12, 2025
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 02-12-add_modeselectionchanged_event branch February 12, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant