Update TimerText only when UI is visible #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ksharma-xyz and the rest of your teammates on |
ksharma-xyz
force-pushed
the
10-14-update_timer_and_stop_updating_when_no_consumers
branch
from
670243d to
cd5cd2e
Compare
ksharma-xyz
changed the title
ksharma-xyz
deleted the
10-14-update_timer_and_stop_updating_when_no_consumers
branch
ksharma-xyz
added
the
achievement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR is to update Timer to Stop Updating when there are no consumers.
This PR addresses the issue where the
updateTimeTextPeriodicallymethod continues to execute even when the app is in the background, as long as the ViewModel is alive.Before
Before-Bug.mov
After
UpdateTimeText-Periodically-UIListens.mov