Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: JourneyCardDetail - Update UI #218

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 19, 2024

TL;DR

Enhanced the JourneyDetailCard component with additional UI elements and created a new JourneyLeg component.

What changed?

  • Updated JourneyDetailCard to include more detailed information:
    • Added time to departure and platform number display
    • Included icons for wheelchair accessibility and travel time
    • Implemented a new layout structure with rows and columns
  • Created a new JourneyLeg component (currently empty, to be implemented)
  • Added a new ic_alert.xml drawable resource

Why make this change?

This change aims to improve the user experience by providing more detailed and visually appealing information about the journey. The enhanced layout and additional icons make it easier for users to quickly understand key details about their trip, such as accessibility options and total travel time.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

This was referenced Oct 19, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 19, 2024 13:06
@ksharma-xyz ksharma-xyz added the UI Design System Related changes label Oct 19, 2024 — with Graphite App
Copy link
Owner Author

Merge activity

  • Oct 19, 9:13 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (Your push would publish a private email address. You can make your email public or disable this protection on GitHub).

@ksharma-xyz ksharma-xyz force-pushed the 10-19-ui_journeycarddetail_-_update_ui branch from 1116ed7 to c1e03f0 Compare October 19, 2024 13:13
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) October 19, 2024 13:18
@ksharma-xyz ksharma-xyz merged commit 0c78345 into main Oct 19, 2024
1 check passed
@ksharma-xyz ksharma-xyz deleted the 10-19-ui_journeycarddetail_-_update_ui branch October 19, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Design System Related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant