Customize platform text based on transport mode #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ksharma-xyz and the rest of your teammates on |
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
10-21-add_logic_to_build_platofrm_text
branch
from
e832ea8 to
82b675c
Compare
Merged
ksharma-xyz
force-pushed
the
10-21-add_support_for_walkingleg_when_leg.transportation.product.class_is_100_or_99
branch
from
ea999aa to
5fdd19c
Compare
Base automatically changed from
10-21-add_support_for_walkingleg_when_leg.transportation.product.class_is_100_or_99
to
main
October 22, 2024 00:14
ksharma-xyz
force-pushed
the
10-21-add_logic_to_build_platofrm_text
branch
from
82b675c to
58f785a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved platform display logic in JourneyDetailCard component
What changed?
buildPlatformTextfunction to generate appropriate platform text based on the transport modeWhy make this change?
This change improves the user experience by providing more accurate and mode-specific platform information. It enhances code maintainability by centralizing the platform text logic in a separate function. The use of
rememberfor filtering transport legs and calculating border colors optimizes component recomposition, potentially improving performance. Additionally, the simplified border color logic makes the code more readable and easier to maintain.