Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transportModeLines nullable and update UI components #237

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 22, 2024

Handle null and empty scenarios for TransportMode list

  • Modify JourneyCard and JourneyDetailCard components to conditionally check if transport modes are present before applying gradient
  • Update TimeTableState to allow nullable transportModeLines
  • Refactor JourneyCard to use a new toColors() extension function for handling null or empty transport mode lists
  • Adjust TimeTableScreen to handle potentially null transportModeLines
  • Update TripResponseMapper to handle scenarios where transport mode information might be missing

These changes improve the robustness of the UI components when dealing with missing or incomplete transport mode data.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz changed the title conditionally check if transport modes are present before applying gradient Make transportModeLines nullable and update UI components Oct 22, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 22, 2024 01:56
@ksharma-xyz ksharma-xyz merged commit 597b7e1 into main Oct 22, 2024
1 check passed
@ksharma-xyz ksharma-xyz deleted the TEMP-FixemptyColorslistinJourneyLeg branch October 22, 2024 02:02
Copy link
Owner Author

Merge activity

  • Oct 21, 10:02 PM EDT: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant