UI: Refactor SavedTripsScreen with Trip object and enhance interactions #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ksharma-xyz and the rest of your teammates on |
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
10-26-button_click_for_save_and_delete_trip
branch
from
387b2e3 to
9ddf74d
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored saved trips functionality and improved UI interactions.
What changed?
SavedTripUiEventto useTripobject instead of string identifierstripIdproperty toTripclass for easier identificationSavedTripCardto acceptTripobject instead of separate origin and destinationSavedTripsScreento handle card clicks and deletionsSavedTripsViewModelfor deleting and clicking saved tripsTimeTableViewModelto usetripIdwhen saving tripsWhy make this change?
This refactoring improves the consistency and maintainability of the saved trips feature. By using the
Tripobject throughout the flow, we reduce the chance of errors and make the code more type-safe. The changes also enhance the user experience by providing more intuitive interactions with saved trips.