UI: Redesign journey card alerts and spacing #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2024
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
11-24-update_collapsible_alert
branch
from
c960b6e to
0aa22b8
Compare
ksharma-xyz
force-pushed
the
11-24-fix_padding_in_expandedjourneycard
branch
from
3988605 to
7d7aff8
Compare
ksharma-xyz
force-pushed
the
11-24-update_collapsible_alert
branch
2 times, most recently
from
927ec01 to
7aa536f
Compare
ksharma-xyz
force-pushed
the
11-24-fix_padding_in_expandedjourneycard
branch
from
7d7aff8 to
d77bcd5
Compare
ksharma-xyz
changed the base branch from
11-24-update_collapsible_alert
to
graphite-base/377
ksharma-xyz
force-pushed
the
11-24-fix_padding_in_expandedjourneycard
branch
from
d77bcd5 to
ad70a64
Compare
ksharma-xyz
force-pushed
the
11-24-fix_padding_in_expandedjourneycard
branch
from
ad70a64 to
4e20d12
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved the journey card UI by refining alert button styling and adjusting padding between transport legs.
What changed?
SmallButtoncomponent with a direct Box implementation for alertsiconSizeparameter from various componentsHow to test?
Why make this change?
To improve visual consistency and user experience by standardizing component styling and spacing throughout the journey card interface. The changes make the alerts more prominent and improve the readability of journey information.