Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: SavedTripCard - update button colors and improve spacing #389

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 27, 2024

TL;DR

Enhanced the visual appearance of the SavedTripCard component with improved spacing and dark theme support.

What changed?

  • Increased vertical padding from 12dp to 16dp in the main card container
  • Adjusted spacing between stop names from 8dp to 16dp
  • Added dark theme support for the star icon, using onSurface color instead of transport mode color
  • Maintained horizontal padding at 12dp for consistency

How to test?

  1. Open the trip planner screen with saved trips
  2. Verify card spacing looks balanced in light mode
  3. Switch to dark mode and confirm the star icon is visible
  4. Check that the spacing between origin and destination stations is comfortable

Why make this change?

The adjustments improve readability and visual hierarchy while ensuring the star icon remains visible in dark mode. The increased spacing provides better visual separation between elements, making the card more scannable for users.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title SavedTrip star button colors UI: SavedTripCard - update button colors and improve spacing Nov 27, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 27, 2024 22:12
Copy link
Owner Author

ksharma-xyz commented Nov 27, 2024

Merge activity

  • Nov 27, 5:12 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 27, 5:13 PM EST: Graphite rebased this pull request as part of a merge.

@ksharma-xyz ksharma-xyz force-pushed the 11-27-savedtrip_star_button_colors branch from 51554bd to 3f2c749 Compare November 27, 2024 22:14
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) November 27, 2024 22:14
@ksharma-xyz ksharma-xyz merged commit 36b65a7 into main Nov 27, 2024
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 11-27-savedtrip_star_button_colors branch November 27, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant