UI: Extract SecondaryButton component and standardize usage #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2024
This was referenced Dec 2, 2024
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
12-02-add_enabled___disabled_property_to_radiobutton
branch
from
341f6d7 to
21bb29c
Compare
ksharma-xyz
force-pushed
the
12-02-ui_create_secondarybutton_component
branch
from
a33ce20 to
2b15dc9
Compare
ksharma-xyz
force-pushed
the
12-02-add_enabled___disabled_property_to_radiobutton
branch
2 times, most recently
from
f8124e3 to
3044cbb
Compare
ksharma-xyz
force-pushed
the
12-02-ui_create_secondarybutton_component
branch
from
2b15dc9 to
876cd18
Compare
ksharma-xyz
changed the base branch from
12-02-add_enabled___disabled_property_to_radiobutton
to
graphite-base/410
ksharma-xyz
force-pushed
the
graphite-base/410
branch
from
3044cbb to
21bedbb
Compare
ksharma-xyz
force-pushed
the
12-02-ui_create_secondarybutton_component
branch
from
876cd18 to
b666026
Compare
ksharma-xyz
force-pushed
the
12-02-ui_create_secondarybutton_component
branch
from
b666026 to
6a0c4a4
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Created a reusable SecondaryButton component and implemented it across date/time selector screens.
What changed?
SecondaryButtoncomposable that encapsulates common button styling and behaviorDateTimeSelectorScreenandTimeTableScreenwith the newSecondaryButtoncomponentScreenshots
Screen.Recording.2024-12-02.at.4.21.22.pm.mov
Why make this change?
Reduces code duplication and ensures consistent button styling across the trip planner interface. This change improves maintainability by centralizing button styling logic and makes it easier to update the design system in the future.