Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Improve HTML text parsing and add iOS tests #418

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 3, 2024

TL;DR

Enhanced HTML text handling for iOS platform and added comprehensive unit tests.

What changed?

  • Added error handling to iOS HTML text processing with runCatching
  • Improved HTML tag replacement by adding support for </ul> and <li> tags
  • Added trim functionality to remove unnecessary whitespace
  • Created unit tests to verify HTML tag replacement functionality

Why make this change?

To improve the reliability of HTML text processing on iOS and ensure consistent text display across different HTML formats. The addition of unit tests provides confidence in the HTML parsing functionality and helps prevent regressions.

Copy link
Owner Author

ksharma-xyz commented Dec 3, 2024

@ksharma-xyz ksharma-xyz changed the title Fix: HtmlText crash - iOS UI: Improve HTML text parsing and add iOS tests Dec 3, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 3, 2024 05:29
@ksharma-xyz ksharma-xyz added the iOS iOS Target label Dec 3, 2024 — with Graphite App
@ksharma-xyz ksharma-xyz changed the title UI: Improve HTML text parsing and add iOS tests iOS: Improve HTML text parsing and add iOS tests Dec 3, 2024
@ksharma-xyz ksharma-xyz added this to the Release v1.0 iOS + Android milestone Dec 3, 2024
@ksharma-xyz ksharma-xyz changed the base branch from 12-03-ios_ready_for_testflight to graphite-base/418 December 3, 2024 05:36
@ksharma-xyz ksharma-xyz force-pushed the 12-03-fix_htmltext_crash_-_ios branch from c4f809e to ba0fd0f Compare December 3, 2024 05:45
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/418 to main December 3, 2024 05:46
@ksharma-xyz ksharma-xyz force-pushed the 12-03-fix_htmltext_crash_-_ios branch from ba0fd0f to 9130525 Compare December 3, 2024 05:46
@ksharma-xyz ksharma-xyz merged commit 036ecf5 into main Dec 3, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Dec 3, 12:54 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 12-03-fix_htmltext_crash_-_ios branch December 3, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS Target
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant