UI: Update ThemeSelection radio button layout #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
changed the title
ksharma-xyz
changed the base branch from
12-14-bump_ios_version
to
graphite-base/455
ksharma-xyz
force-pushed
the
graphite-base/455
branch
from
9882079 to
b63ec50
Compare
ksharma-xyz
force-pushed
the
12-14-update_background_color_selection_shape_of_theme_selection_radio_buttons
branch
from
3b59ba8 to
284ef8b
Compare
ksharma-xyz
force-pushed
the
12-14-update_background_color_selection_shape_of_theme_selection_radio_buttons
branch
from
284ef8b to
d1278f5
Compare
Merge activity
|
ksharma-xyz
deleted the
12-14-update_background_color_selection_shape_of_theme_selection_radio_buttons
branch
ksharma-xyz
added a commit
that referenced
this pull request
Dec 14, 2024
This reverts commit 056884e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated the theme selection screen's radio button layout to display selected background in a even odd pattern.
What changed?
TransportModeRadioButtontoThemeSelectionRadioButtonitemstoitemsIndexedto track even/odd positioningScreenshots
Screen.Recording.2024-12-14.at.2.08.39.pm.mov
Why make this change?
Improves the visual presentation