Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coroutines exception handling utilities #540

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 13, 2025

TL;DR

Added coroutine exception handling utilities and integrated them with the logging system.

Fixes crash - when app is opened with no internet, it was crashing.

What changed?

  • Created a new coroutines-ext module with exception handling utilities
  • Added launchWithExceptionHandler extension function for CoroutineScope
  • Simplified logging interface by removing redundant throwable parameter
  • Integrated exception handling in RemoteConfig implementation
  • Added Compose runtime dependencies to support coroutine integration

Why make this change?

To provide a standardized way of handling coroutine exceptions across the application, ensuring that errors are properly logged and don't crash the app. This improves debugging capabilities and application stability.

Copy link
Owner Author

ksharma-xyz commented Jan 13, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title BUG: Fix crash when no internet Add coroutines exception handling utilities Jan 13, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 13, 2025 05:43
@ksharma-xyz ksharma-xyz merged commit c7d1673 into main Jan 13, 2025
4 checks passed
Copy link
Owner Author

Merge activity

  • Jan 13, 12:57 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 01-13-bug_fix_crash_when_no_internet branch January 13, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant