Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO: Move file storage and zip management to dedicated module #573

Open
wants to merge 8 commits into
base: 01-26-unpackzip_files
Choose a base branch
from

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 26, 2025

Create new :core:io module for file operations

  • Creates new :core:io module for handling file operations across platforms
  • Implements ZipFileManager interface with RealZipFileManager implementation
  • Provides platform-specific FileStorage implementations for Android and iOS
  • Uses SYSTEM_TEMPORARY_DIRECTORY for iOS file storage
  • Implements suspend functions with IO dispatcher for file operations
  • Adds unified path creation logic for unzipping files
  • Moves file storage logic from gtfs-static module to core:io
  • Provides ioModule with ZipFileManager dependency
  • Updates gtfs-static module to use new core:io module

The changes improve code organization by centralizing file operations in a dedicated module while maintaining platform-specific implementations where needed.

Copy link
Owner Author

ksharma-xyz commented Jan 26, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Create new module :core:io IO: Move file storage and zip management to dedicated module Jan 26, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 26, 2025 11:12
@ksharma-xyz ksharma-xyz force-pushed the 01-26-unpackzip_files branch from ce96a75 to a8a3b5f Compare January 26, 2025 23:30
@ksharma-xyz ksharma-xyz force-pushed the 01-26-create_new_module_core_io branch from 4496b84 to 521b132 Compare January 26, 2025 23:30
@ksharma-xyz ksharma-xyz force-pushed the 01-26-unpackzip_files branch from a8a3b5f to b1b6d38 Compare January 27, 2025 10:12
@ksharma-xyz ksharma-xyz force-pushed the 01-26-create_new_module_core_io branch from 521b132 to 9b9db7d Compare January 27, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant