Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update TransportModeChip text color and border styling #603

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Feb 11, 2025

TL;DR

Updated the TransportModeChip and TransportModeIcon components to improve text contrast and visual consistency

What changed?

  • Modified text color in TransportModeChip to use a contrast-aware foreground color
  • Reduced border width from 3dp to 2dp in TransportModeChip
  • Added ContentAlpha token to TransportModeIcon to ensure 100% opacity
  • Removed redundant color property from TransportModeIcon text

How to test?

  1. Navigate to the trip planner screen
  2. Verify that transport mode chips have proper text contrast when selected
  3. Confirm that transport mode icons display with full opacity
  4. Check that the border width appears visually balanced

Why make this change?

To enhance readability and visual consistency across transport mode components while ensuring proper contrast ratios for accessibility. The changes also streamline the implementation by removing redundant styling properties.

@ksharma-xyz ksharma-xyz changed the title Update border UI: Update TransportModeChip text color and border styling Feb 11, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review February 11, 2025 21:28
@ksharma-xyz ksharma-xyz force-pushed the 02-11-display_transportmodechip_row branch from 0924d54 to 5470e05 Compare February 12, 2025 11:35
@ksharma-xyz ksharma-xyz force-pushed the 02-11-display_transportmodechip_row branch from 5470e05 to f4a6d85 Compare February 12, 2025 11:36
@ksharma-xyz ksharma-xyz force-pushed the 02-12-update_border branch 2 times, most recently from 66d03f8 to 27228e5 Compare February 12, 2025 11:55
@ksharma-xyz ksharma-xyz changed the base branch from 02-11-display_transportmodechip_row to graphite-base/603 February 12, 2025 11:59
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/603 to main February 12, 2025 11:59
@ksharma-xyz ksharma-xyz merged commit 26dd420 into main Feb 12, 2025
2 checks passed
Copy link
Owner Author

Merge activity

  • Feb 12, 7:21 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 02-12-update_border branch February 12, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant