This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fix scan for body parameter in ksonnet.parsePaths() #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shomron
force-pushed
the
dont-point-to-range-variable
branch
from
ab1f83d to
bedba2a
Compare
Previously, body was assigned the address of the iteration variable. Since this variable is reused, additional parameters following the body would overwrite it and be used in its stead, leading to undefined behavior (such as the panic described in the linked issue). Addresses ksonnet/ksonnet#883 Signed-off-by: Oren Shomron <shomron@gmail.com>
shomron
force-pushed
the
dont-point-to-range-variable
branch
from
bedba2a to
c848e79
Compare
bryanl
approved these changes
Nov 5, 2018
shomron
added a commit
to shomron/ksonnet
that referenced
this pull request
Nov 5, 2018
…ody parameter in cluster OpenAPI spec Incorporates ksonnet/ksonnet-lib#155 Fixes ksonnet#883 Signed-off-by: Oren Shomron <shomron@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, body was assigned the address of the iteration variable.
Since this variable is reused, additional parameters following the body would
overwrite it and be used in its stead, leading to undefined behavior
(such as the panic described in the linked issue).
Addresses ksonnet/ksonnet#883
Signed-off-by: Oren Shomron shomron@gmail.com