-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added listallinfo command #72
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
listallinfo
(likelistall
) lists directories, not just songs. Currently, thelistall()
method is incomplete/incorrect (it does not handle directories, see also issue listall() output is broken #64).- This comment should be altered to remove it out of TODO.
- A test would be appreciated.
src/client.rs
Outdated
@@ -203,6 +203,11 @@ impl<S: Read + Write> Client<S> { | |||
self.run_command("listall", ()).and_then(|_| self.read_structs("file")) | |||
} | |||
|
|||
/// lists all songs in the database with metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// lists all songs in the database with metadata | |
/// Lists all songs in the database with metadata |
I have corrected the incorrect docstring and removed the TODO. Again, I'm sorry I cannot be more of use for this project. |
Hi, just to let you know, I thought your patch was very useful, so I've included it in my fork (i just copied the exact patch from the PR). I hope you don't mind! |
For a personal project of mine, I needed to have quick access to mpd "listallinfo" command.
Since the mpd "listall" command was already implemented, and a Vec structure could already be built from the mpd response, I added the mpd "listallinfo" command. After testing the new command in my project, I had the behaviour I expected.
Let me know if I need to add more code for the pr to be valid.