-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port circleparse changes #25
Conversation
Since you're the defacto maintainer of osrparse now, I'll leave this up to you, but consider adding type annotations/mypy to this library since you're actively looking at it now. I've always found types pretty handy. |
Good point. I've added type annotations to all public-facing members (adding them to internal methods doesn't seem worth the trouble). |
@kszlim I'm afraid there's a merge rule setup on the master branch which means I can't merge without an approving review (and I can't approve my own pr). Up to you if you want to remove that rule or if you want to keep a rubber stamp on all future prs. |
@tybug removed it |
This is a port of the past two years (sounds more impressive than it really is) of changes over at the circleparse fork. After this circleparse will become defunct and circleguard will use osrparse instead.
There are quite a few changes here. The major ones are:
mod_combination
is now a bitwise enum instead of a list of enums/get_score
endpoint only gives us the replay data and nothing else)