Skip to content
This repository has been archived by the owner on Jul 9, 2022. It is now read-only.

Eslint/no restricted syntax #214

Closed
wants to merge 11 commits into from
Closed

Conversation

ktmud
Copy link
Owner

@ktmud ktmud commented Sep 18, 2020

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud ktmud force-pushed the eslint/no-restricted-syntax branch 2 times, most recently from edfbad4 to 5fc0237 Compare September 18, 2020 04:59
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #214 into master will decrease coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   61.56%   60.57%   -0.99%     
==========================================
  Files         815      382     -433     
  Lines       38335    24132   -14203     
  Branches     3601        0    -3601     
==========================================
- Hits        23602    14619    -8983     
+ Misses      14547     9513    -5034     
+ Partials      186        0     -186     
Flag Coverage Δ
#javascript ?
#python 60.57% <ø> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/database/views.py 62.30% <0.00%> (-25.14%) ⬇️
superset/db_engine_specs/mysql.py 79.16% <0.00%> (-12.50%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 82.97% <0.00%> (-8.52%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/presto.py 73.54% <0.00%> (-8.08%) ⬇️
superset/db_engine_specs/base.py 79.94% <0.00%> (-7.32%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/views/database/forms.py 83.33% <0.00%> (-5.56%) ⬇️
superset/views/core.py 70.86% <0.00%> (-3.61%) ⬇️
... and 435 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21a354...11ceb8c. Read the comment docs.

@cypress
Copy link

cypress bot commented Sep 18, 2020



Test summary

118 4 7 0


Run details

Project Superset
Status Failed
Commit bd3021b02f
Started Sep 18, 2020 4:11 PM
Ended Sep 18, 2020 4:28 PM
Duration 16:57 💡
OS Linux Ubuntu - 18.04
Browser Chrome 85

View run in Cypress Dashboard ➡️


Failures

card_view.test.ts Failed
1 Dashboard card view > should load cards
2 Dashboard card view > should sort correctly
filter.test.ts Failed
1 dashboard filters > should filter by published correctly
list_view.test.ts Failed
1 dashboard list view > should load rows

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ktmud ktmud force-pushed the eslint/no-restricted-syntax branch 2 times, most recently from 65ddb70 to 4d73a58 Compare September 18, 2020 06:37
@cypress
Copy link

cypress bot commented Sep 18, 2020



Test summary

119 3 7 0


Run details

Project Superset
Status Failed
Commit ce77c58419 ℹ️
Started Sep 18, 2020 4:17 PM
Ended Sep 18, 2020 4:37 PM
Duration 19:07 💡
OS Linux Ubuntu - 18.04
Browser Chrome 85

View run in Cypress Dashboard ➡️


Failures

card_view.test.ts Failed
1 Dashboard card view > should load cards
2 Dashboard card view > should sort correctly
list_view.test.ts Failed
1 dashboard list view > should load rows

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ktmud ktmud force-pushed the eslint/no-restricted-syntax branch from 4d73a58 to bd3021b Compare September 18, 2020 16:05
@ktmud ktmud force-pushed the eslint/no-restricted-syntax branch from bd3021b to 11ceb8c Compare September 18, 2020 16:49
@github-actions
Copy link

WARNING: Prefer TypeScript

Looks like your PR contains new .js or .jsx files:

superset-frontend/spec/javascripts/explore/fixtures.jsx

As decided in SIP-36, all new frontend code should be written in TypeScript. Please convert above files to TypeScript then re-request review.

@ktmud ktmud closed this Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants