Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following up for #123 #133

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Following up for #123 #133

merged 4 commits into from
Sep 14, 2023

Conversation

ktock
Copy link
Owner

@ktock ktock commented Sep 14, 2023

  • a1fe957 : this flag name is confusing because we're not using QEMU (while relying on the protocol). so rename it to net=socket
  • 6b8965e : some descriptions are confusing because we can't use gvisor-tap-vsock as-is but we need to use c2w-net or c2w-net-proxy for networking of containers on wasm.
  • 38ab1f0 : mention about forbidden headers which are controlled by the browser and can't be changed from the container and the proxy. These headers added by the container will be modified or ignored by the browser.
  • ff03e50 letting browser set this allows more requests becoming simple requests that reduces CORS preflight and the container can access many more sites. (this behaviour is the same as chrome that silently drops User-Agent header from Fetch requests https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_header_name )

Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@ktock ktock changed the title Followup Following up for #123 Sep 14, 2023
@ktock ktock merged commit b3e540b into main Sep 14, 2023
13 checks passed
@ktock ktock deleted the followup branch September 14, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant