KTOR-4379 Validate body size equals Content-Length #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
force-pushed
the
e5l/validate-content-length
branch
from
4721952 to
a36b62c
Compare
|
Please check CI |
|
@rsinukov, thanks. done |
|
JS and Native builds are still failing |
e5l
force-pushed
the
e5l/validate-content-length
branch
from
1a4b288 to
2996cbd
Compare
|
@rsinukov, thanks. Updated |
rsinukov
approved these changes
Jun 24, 2022
|
|
||
| if (!upgraded && event is LastHttpContent) { | ||
| current.close() | ||
| checkCurrentLengthAndClose() |
There was a problem hiding this comment.
Isn't it redundant, since this check is in finally block?
There was a problem hiding this comment.
Nope: the next message can be a new channel in the pipeline or upgrade
| current?.close() | ||
| current = event | ||
| is ChannelEvent -> { | ||
| checkCurrentLengthAndClose() |
ktor-server/ktor-server-test-host/jvm/src/io/ktor/server/testing/EngineTestBaseJvm.kt
Outdated
Show resolved
Hide resolved
ktor-server/ktor-server-test-suites/jvm/src/io/ktor/server/testing/suites/ContentTestSuite.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KTOR-4379